From b9e7c03a28c187f4abe105b3230e5e796e8db7b9 Mon Sep 17 00:00:00 2001 From: Mariano Uvalle Date: Fri, 10 Nov 2023 16:43:22 +0000 Subject: [PATCH] Read password securely from Stdin --- cmd/cli/register.go | 5 ++--- cmd/cli/registerDevice.go | 6 ++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/cmd/cli/register.go b/cmd/cli/register.go index ee35635..8c9b1fe 100644 --- a/cmd/cli/register.go +++ b/cmd/cli/register.go @@ -6,25 +6,24 @@ import ( "github.com/spf13/cobra" "github.com/AYM1607/ccclip/internal/configfile" + "github.com/AYM1607/ccclip/pkg/input" ) var email string -var password string func init() { rootCmd.AddCommand(registerCmd) registerCmd.Flags().StringVarP(&email, "email", "e", "", "email will be your login identifier") - registerCmd.Flags().StringVarP(&password, "password", "p", "", "password will secure your account") registerCmd.MarkFlagRequired("email") - registerCmd.MarkFlagRequired("password") } var registerCmd = &cobra.Command{ Use: "register", Short: "Register a user with a given email and password", RunE: func(cmd *cobra.Command, args []string) error { + password := input.ReadPassword() err := apiclient.Register(email, password) if err != nil { return fmt.Errorf("could not register user: %w", err) diff --git a/cmd/cli/registerDevice.go b/cmd/cli/registerDevice.go index cb5c2ae..4d7a911 100644 --- a/cmd/cli/registerDevice.go +++ b/cmd/cli/registerDevice.go @@ -7,14 +7,11 @@ import ( "github.com/AYM1607/ccclip/internal/configfile" "github.com/AYM1607/ccclip/pkg/crypto" + "github.com/AYM1607/ccclip/pkg/input" ) func init() { rootCmd.AddCommand(registerDeviceCommand) - - registerDeviceCommand.Flags().StringVarP(&password, "password", "p", "", "password for your account") - - registerDeviceCommand.MarkFlagRequired("password") } var registerDeviceCommand = &cobra.Command{ @@ -37,6 +34,7 @@ var registerDeviceCommand = &cobra.Command{ pvk := crypto.NewPrivateKey() pbk := pvk.PublicKey() + password := input.ReadPassword() res, err := apiclient.RegisterDevice(cc.Email, password, pbk.Bytes()) if err != nil { return err