jmug/do_more
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Modified Google Sign In provider to disconnect form both firebase and Google on sign out, added the apripriate test

Browse source
This commit is contained in:
Mariano Uvalle 2019-02-27 00:16:15 -06:00
parent 0eebd668d6
commit ac0aed257d
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/src/resources/google_sign_in_provider.dart
View file

@ -39,6 +39,7 @@ class GoogleSignInProvider {
}
Future<void> signOut() async {
await _googleSignIn.disconnect();
await _auth.signOut();
}
}

4
test/src/resources/google_sign_in_provider_test.dart
View file

@ -38,11 +38,13 @@ main() {
test('should sign out a user', () {
final auth = MockFirebaseAuth();
final provider = GoogleSignInProvider(null, auth);
final googleSignIn = MockGoogleSignIn();
final provider = GoogleSignInProvider(googleSignIn, auth);
when(auth.signOut()).thenAnswer((_) => Future.value());
expect(provider.signOut(), completes);
verify(googleSignIn.disconnect());
});
});
}