Fix typs and add extra clarifications for segment and the http server.

This commit is contained in:
Mariano Uvalle 2021-08-05 16:26:54 -05:00
parent 60f6040fe3
commit 4553be4b6d
2 changed files with 3 additions and 2 deletions

View file

@ -52,7 +52,7 @@ func newSegment(dir string, baseOffset uint64, c Config) (*segment, error) {
}
// If Read(-1) returns an error it means that the index's underlying file
// and this itself is empty.
// and thus itself is empty.
if off, _, err := s.index.Read(-1); err != nil {
s.nextOffset = baseOffset
} else {
@ -138,6 +138,7 @@ func (s *segment) Remove() error {
// nearestMultiple returns the nearest and lesser multiple of k in j.
// example: nearestMultiple(9, 4) = 8
func nearestMultiple(j, k uint64) uint64 {
// This code comes from the book. is this check necessary since the passed values are uint64?
if j >= 0 {
return (j / k) * k
}

View file

@ -67,7 +67,7 @@ func (s *httpServer) handleProduce(w http.ResponseWriter, r *http.Request) {
}
res := ProduceResponse{Offset: off}
// The header gets overrided if there's an encoding error.
// The header gets overwritten if there's an encoding error.
w.WriteHeader(http.StatusCreated)
err = json.NewEncoder(w).Encode(res)
if err != nil {